etc: licenseck: don't hardcode a specific year #11314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Oh dear it seems I'm a little late to the party, but I've also fixed this in #11313 as part of alexcrichton@3480a32 which still validates the year, but uses the current date and refactors things a bit. |
bors
added a commit
that referenced
this pull request
Jan 5, 2014
- don't check for an hardcoded copyright claim year, check the 2 surrounding strings instead - logic: if either the `//` or `#`-style copyright patterns are found, don't invalidate - cleanup hardcoded content and streamline the few files with different line breaks r? @brson
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 17, 2023
…_block, r=Centri3 Correctly handle async blocks for NEEDLESS_PASS_BY_REF_MUT Fixes rust-lang/rust-clippy#11299. The problem was that the `async block`s are popping a closure which we didn't go into, making it miss the mutable access to the variables. cc `@Centri3` changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 24, 2023
…_block, r=Centri3 Correctly handle async blocks for NEEDLESS_PASS_BY_REF_MUT Fixes rust-lang/rust-clippy#11299. The problem was that the `async block`s are popping a closure which we didn't go into, making it miss the mutable access to the variables. cc `@Centri3` changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 24, 2023
…_block, r=Centri3 Correctly handle async blocks for NEEDLESS_PASS_BY_REF_MUT Fixes rust-lang/rust-clippy#11299. The problem was that the `async block`s are popping a closure which we didn't go into, making it miss the mutable access to the variables. cc `@Centri3` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//or#-style copyright patterns are found, don't invalidater? @brson